Use llvm::drop_begin (NFC)

clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp

@@ -113,9 +113,8 @@ void ForwardingReferenceOverloadCheck::check(
 
   // Every parameter after the first must have a default value.
   const auto *Ctor = Result.Nodes.getNodeAs<CXXConstructorDecl>("ctor");
-  for (auto *Iter = Ctor->param_begin() + 1; Iter != Ctor->param_end();
-       ++Iter) {
-    if (!(*Iter)->hasDefaultArg())
+  for (const auto *Param : llvm::drop_begin(Ctor->parameters())) {
+    if (!Param->hasDefaultArg())
       return;
   }
   bool EnabledCopy = false, DisabledCopy = false, EnabledMove = false,

clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp

@@ -145,8 +145,8 @@ initializerForParams(const SmallVector<MethodParameter, 8> &Params,
     Stream << llvm::formatv("- (instancetype)initWith{0}:({1}){2}",
                             capitalize(First.Name.trim().str()), First.Type,
                             First.Name);
-    for (auto It = Params.begin() + 1; It != Params.end(); ++It)
-      Stream << llvm::formatv(" {0}:({1}){0}", It->Name, It->Type);
+    for (const auto &It : llvm::drop_begin(Params))
+      Stream << llvm::formatv(" {0}:({1}){0}", It.Name, It.Type);
 
     if (GenerateImpl) {
       Stream <<

clang/lib/CodeGen/TargetInfo.cpp

@@ -11915,8 +11915,8 @@ llvm::Function *AMDGPUTargetCodeGenInfo::createEnqueuedBlockKernel(
   auto *Cast = Builder.CreatePointerCast(BlockPtr, InvokeFT->getParamType(0));
   llvm::SmallVector<llvm::Value *, 2> Args;
   Args.push_back(Cast);
-  for (auto I = F->arg_begin() + 1, E = F->arg_end(); I != E; ++I)
-    Args.push_back(I);
+  for (llvm::Argument &A : llvm::drop_begin(F->args()))
+    Args.push_back(&A);
   llvm::CallInst *call = Builder.CreateCall(Invoke, Args);
   call->setCallingConv(Invoke->getCallingConv());
   Builder.CreateRetVoid();

lld/ELF/SyntheticSections.cpp

@@ -1895,9 +1895,9 @@ bool AndroidPackedRelocationSection<ELFT>::updateAllocSize() {
     add(config->wordsize);
     add(target->relativeRel);
     if (config->isRela) {
-      for (auto i = g.begin() + 1, e = g.end(); i != e; ++i) {
-        add(i->r_addend - addend);
-        addend = i->r_addend;
+      for (const auto &i : llvm::drop_begin(g)) {
+        add(i.r_addend - addend);
+        addend = i.r_addend;
       }
     }
 

llvm/lib/Target/PowerPC/PPCLoopInstrFormPrep.cpp

@@ -1049,16 +1049,15 @@ bool PPCLoopInstrFormPrep::rewriteLoadStores(
   SmallPtrSet<Value *, 16> NewPtrs;
   NewPtrs.insert(Base.first);
 
-  for (auto I = std::next(BucketChain.Elements.begin()),
-       IE = BucketChain.Elements.end(); I != IE; ++I) {
-    Value *Ptr = getPointerOperandAndType(I->Instr);
+  for (const BucketElement &BE : llvm::drop_begin(BucketChain.Elements)) {
+    Value *Ptr = getPointerOperandAndType(BE.Instr);
     assert(Ptr && "No pointer operand");
     if (NewPtrs.count(Ptr))
       continue;
 
     Instruction *NewPtr = rewriteForBucketElement(
-        Base, *I,
-        I->Offset ? cast<SCEVConstant>(I->Offset)->getValue() : nullptr,
+        Base, BE,
+        BE.Offset ? cast<SCEVConstant>(BE.Offset)->getValue() : nullptr,
         DeletedPtrs);
     assert(NewPtr && "wrong rewrite!\n");
     NewPtrs.insert(NewPtr);