OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 2
Code Issues Packages Projects Releases Wiki Activity

[InstCombine] Bail out of casting calls when a conversion from/to byval is involved. 

Fixes #58307

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D135738
This commit is contained in:
Mike Hommey 2022-10-23 09:49:16 +02:00 committed by Sylvestre Ledru
parent 00c2eb214d
commit 86e57e66da
3 changed files with 36 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
View File

@ -3395,6 +3395,10 @@ bool InstCombinerImpl::transformConstExprCastCall(CallBase &Call) {
if (CallerPAL.hasParamAttr(i, Attribute::SwiftError))
return false;
if (CallerPAL.hasParamAttr(i, Attribute::ByVal) !=
Callee->getAttributes().hasParamAttr(i, Attribute::ByVal))
return false; // Cannot transform to or from byval.
// If the parameter is passed as a byval argument, then we have to have a
// sized type and the sized type has to have the same size as the old type.
if (ParamTy != ActTy && CallerPAL.hasParamAttr(i, Attribute::ByVal)) {

3
llvm/test/Transforms/InstCombine/byval.ll
View File

@ -7,8 +7,7 @@ declare void @add_byval_callee_2(double* byval(double))
define void @add_byval(i64* %in) {
; CHECK-LABEL: @add_byval(
; CHECK-NEXT: [[TMP1:%.*]] = bitcast i64* [[IN:%.*]] to double*
; CHECK-NEXT: call void @add_byval_callee(double* byval(double) [[TMP1]])
; CHECK-NEXT: call void bitcast (void (double*)* @add_byval_callee to void (i64*)*)(i64* byval(i64) [[IN:%.*]])
; CHECK-NEXT: ret void
;
%tmp = bitcast void (double*)* @add_byval_callee to void (i64*)*

31
llvm/test/Transforms/InstCombine/cast-byval.ll Normal file
View File

@ -0,0 +1,31 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; Check that function calls involving conversion from/to byval aren't transformed.
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
%Foo = type { i64 }
define i64 @foo (ptr byval(%Foo) %foo) {
; CHECK-LABEL: @foo(
; CHECK-NEXT: [[TMP1:%.*]] = load i64, ptr [[FOO:%.*]], align 4
; CHECK-NEXT: ret i64 [[TMP1]]
;
%1 = load i64, ptr %foo, align 4
ret i64 %1
}
define i64 @bar(i64 %0) {
; CHECK-LABEL: @bar(
; CHECK-NEXT: [[TMP2:%.*]] = tail call i64 @foo(i64 [[TMP0:%.*]])
; CHECK-NEXT: ret i64 [[TMP2]]
;
%2 = tail call i64 @foo(i64 %0)
ret i64 %2
}
define i64 @qux(ptr byval(%Foo) %qux) {
; CHECK-LABEL: @qux(
; CHECK-NEXT: [[TMP1:%.*]] = tail call i64 @bar(ptr nonnull byval([[FOO:%.*]]) [[QUX:%.*]])
; CHECK-NEXT: ret i64 [[TMP1]]
;
%1 = tail call i64 @bar(ptr byval(%Foo) %qux)
ret i64 %1
}