OSchip
/
llvm-project
mirror of https://github.com/THU-DSP-LAB/llvm-project.git
13
0
Fork 2
Code Issues Packages Projects Releases Wiki Activity

[Instcombine] Code refactors for foldSelectOpOp; NFC 

Reuse the code about find common operator.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D139075
This commit is contained in:
chenglin.bi 2022-12-02 22:26:20 +08:00
parent d0650d1089
commit 683b9fc7bd
1 changed files with 63 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

101
llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
View File

@ -314,15 +314,48 @@ Instruction *InstCombinerImpl::foldSelectOpOp(SelectInst &SI, Instruction *TI,
TI->getType()); TI->getType());
} }
Value *OtherOpT, *OtherOpF;
bool MatchIsOpZero;
auto getCommonOp = [&](Instruction *TI, Instruction *FI,
bool Commute) -> Value * {
Value *CommonOp = nullptr;
if (TI->getOperand(0) == FI->getOperand(0)) {
CommonOp = TI->getOperand(0);
OtherOpT = TI->getOperand(1);
OtherOpF = FI->getOperand(1);
MatchIsOpZero = true;
} else if (TI->getOperand(1) == FI->getOperand(1)) {
CommonOp = TI->getOperand(1);
OtherOpT = TI->getOperand(0);
OtherOpF = FI->getOperand(0);
MatchIsOpZero = false;
} else if (!Commute) {
return nullptr;
} else if (TI->getOperand(0) == FI->getOperand(1)) {
CommonOp = TI->getOperand(0);
OtherOpT = TI->getOperand(1);
OtherOpF = FI->getOperand(0);
MatchIsOpZero = true;
} else if (TI->getOperand(1) == FI->getOperand(0)) {
CommonOp = TI->getOperand(1);
OtherOpT = TI->getOperand(0);
OtherOpF = FI->getOperand(1);
MatchIsOpZero = true;
}
return CommonOp;
};
if (TI->hasOneUse() || FI->hasOneUse()) {
// Cond ? -X : -Y --> -(Cond ? X : Y) // Cond ? -X : -Y --> -(Cond ? X : Y)
Value *X, *Y; Value *X, *Y;
if (match(TI, m_FNeg(m_Value(X))) && match(FI, m_FNeg(m_Value(Y))) && if (match(TI, m_FNeg(m_Value(X))) && match(FI, m_FNeg(m_Value(Y)))) {
(TI->hasOneUse() || FI->hasOneUse())) { // Intersect FMF from the fneg instructions and union those with the
// Intersect FMF from the fneg instructions and union those with the select. // select.
FastMathFlags FMF = TI->getFastMathFlags(); FastMathFlags FMF = TI->getFastMathFlags();
FMF &= FI->getFastMathFlags(); FMF &= FI->getFastMathFlags();
FMF |= SI.getFastMathFlags(); FMF |= SI.getFastMathFlags();
Value *NewSel = Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI); Value *NewSel =
Builder.CreateSelect(Cond, X, Y, SI.getName() + ".v", &SI);
if (auto *NewSelI = dyn_cast<Instruction>(NewSel)) if (auto *NewSelI = dyn_cast<Instruction>(NewSel))
NewSelI->setFastMathFlags(FMF); NewSelI->setFastMathFlags(FMF);
Instruction *NewFNeg = UnaryOperator::CreateFNeg(NewSel); Instruction *NewFNeg = UnaryOperator::CreateFNeg(NewSel);
@ -330,31 +363,19 @@ Instruction *InstCombinerImpl::foldSelectOpOp(SelectInst &SI, Instruction *TI,
return NewFNeg; return NewFNeg;
} }
// Min/max intrinsic with a common operand can have the common operand pulled // Min/max intrinsic with a common operand can have the common operand
// after the select. This is the same transform as below for binops, but // pulled after the select. This is the same transform as below for binops,
// specialized for intrinsic matching and without the restrictive uses clause. // but specialized for intrinsic matching and without the restrictive uses
// clause.
auto *TII = dyn_cast<IntrinsicInst>(TI); auto *TII = dyn_cast<IntrinsicInst>(TI);
auto *FII = dyn_cast<IntrinsicInst>(FI); auto *FII = dyn_cast<IntrinsicInst>(FI);
if (TII && FII && TII->getIntrinsicID() == FII->getIntrinsicID() && if (TII && FII && TII->getIntrinsicID() == FII->getIntrinsicID()) {
(TII->hasOneUse() || FII->hasOneUse())) { if (match(TII, m_MaxOrMin(m_Value(), m_Value()))) {
Value *T0, *T1, *F0, *F1; if (Value *MatchOp = getCommonOp(TI, FI, true)) {
if (match(TII, m_MaxOrMin(m_Value(T0), m_Value(T1))) && Value *NewSel =
match(FII, m_MaxOrMin(m_Value(F0), m_Value(F1)))) { Builder.CreateSelect(Cond, OtherOpT, OtherOpF, "minmaxop", &SI);
if (T0 == F0) { return CallInst::Create(TII->getCalledFunction(), {NewSel, MatchOp});
Value *NewSel = Builder.CreateSelect(Cond, T1, F1, "minmaxop", &SI);
return CallInst::Create(TII->getCalledFunction(), {NewSel, T0});
} }
if (T0 == F1) {
Value *NewSel = Builder.CreateSelect(Cond, T1, F0, "minmaxop", &SI);
return CallInst::Create(TII->getCalledFunction(), {NewSel, T0});
}
if (T1 == F0) {
Value *NewSel = Builder.CreateSelect(Cond, T0, F1, "minmaxop", &SI);
return CallInst::Create(TII->getCalledFunction(), {NewSel, T1});
}
if (T1 == F1) {
Value *NewSel = Builder.CreateSelect(Cond, T0, F0, "minmaxop", &SI);
return CallInst::Create(TII->getCalledFunction(), {NewSel, T1});
} }
} }
} }
@ -370,33 +391,9 @@ Instruction *InstCombinerImpl::foldSelectOpOp(SelectInst &SI, Instruction *TI,
return nullptr; return nullptr;
// Figure out if the operations have any operands in common. // Figure out if the operations have any operands in common.
Value *MatchOp, *OtherOpT, *OtherOpF; Value *MatchOp = getCommonOp(TI, FI, TI->isCommutative());
bool MatchIsOpZero; if (!MatchOp)
if (TI->getOperand(0) == FI->getOperand(0)) {
MatchOp = TI->getOperand(0);
OtherOpT = TI->getOperand(1);
OtherOpF = FI->getOperand(1);
MatchIsOpZero = true;
} else if (TI->getOperand(1) == FI->getOperand(1)) {
MatchOp = TI->getOperand(1);
OtherOpT = TI->getOperand(0);
OtherOpF = FI->getOperand(0);
MatchIsOpZero = false;
} else if (!TI->isCommutative()) {
return nullptr; return nullptr;
} else if (TI->getOperand(0) == FI->getOperand(1)) {
MatchOp = TI->getOperand(0);
OtherOpT = TI->getOperand(1);
OtherOpF = FI->getOperand(0);
MatchIsOpZero = true;
} else if (TI->getOperand(1) == FI->getOperand(0)) {
MatchOp = TI->getOperand(1);
OtherOpT = TI->getOperand(0);
OtherOpF = FI->getOperand(1);
MatchIsOpZero = true;
} else {
return nullptr;
}
// If the select condition is a vector, the operands of the original select's // If the select condition is a vector, the operands of the original select's
// operands also must be vectors. This may not be the case for getelementptr // operands also must be vectors. This may not be the case for getelementptr