[lldb] [testsuite] Fix a regression of TestCppScope.py

This is a regression since:
  [lldb][NFC] Modernize lang/cpp/scope test
  acb0b99c8e
  rGacb0b99c8e4f

  File "/home/jkratoch/redhat/llvm-monorepo/lldb/test/API/lang/cpp/scope/TestCppScope.py", line 19, in test
    self.assertEqual(global_var_names, expected_var_names)
  AssertionError: Lists differ: ['C::a', 'A::a', 'B::a', '::a'... != ['A::a', 'B::a', 'C::a', '::a'...
  First differing element 0:
  C::a
  A::a
  - ['C::a', 'A::a', 'B::a', '::a']
  + ['A::a', 'B::a', 'C::a', '::a']

ManualDWARFIndex using NameToDIE does not sort alphabetically:
    // This is only for uniqueness, not lexicographical ordering, so we can
    // just compare pointers.
    return uintptr_t(lhs.GetCString()) < uintptr_t(rhs.GetCString());
This commit is contained in:
Jan Kratochvil 2020-04-18 10:44:33 +02:00
parent 60ce987bf3
commit 239093f30c
1 changed files with 3 additions and 2 deletions

View File

@ -14,8 +14,9 @@ class TestCase(TestBase):
# Test that global variables contain the right scope operators.
global_vars = self.frame().GetVariables(False, False, True, False)
global_var_names = [v.GetName() for v in global_vars]
expected_var_names = ["A::a", "B::a", "C::a", "::a"]
# ManualDWARFIndex using NameToDIE does not sort alphabetically.
global_var_names = sorted([v.GetName() for v in global_vars])
expected_var_names = ["::a", "A::a", "B::a", "C::a"]
self.assertEqual(global_var_names, expected_var_names)
# Test lookup in scopes.