From 0851970af5771f6721c29d066c88a72db823ba83 Mon Sep 17 00:00:00 2001 From: Jesko Appelfeller Date: Tue, 8 Feb 2022 08:30:59 -0500 Subject: [PATCH] Make run-clang-tidy.py print the configured checks correctly The test invocation at the start of run-clang-tidy.py (line 257) prints all enabled checks - meaning either the default set or anything configured via the -checks option. If any checks were (un-)configured via the -config option, these are not printed. This is confusing to the user, since the list of checks that are printed may be different from the list of checks that are used by the non-testing calls to clang-tidy, where the -config option is passed correctly. This patch adds the -config option to the test invocation of clang-tidy at the start of the script. This means that checks (un-)configured via the -config option (rather than the -checks option) are applied correctly, when printing the list of enabled checks. --- clang-tools-extra/clang-tidy/tool/run-clang-tidy.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py index e6cff6a7414d..090646c1b061 100755 --- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py +++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py @@ -254,12 +254,12 @@ def main(): build_path = find_compilation_database(db_path) try: - invocation = [args.clang_tidy_binary, '-list-checks'] - if args.allow_enabling_alpha_checkers: - invocation.append('-allow-enabling-analyzer-alpha-checkers') - invocation.append('-p=' + build_path) - if args.checks: - invocation.append('-checks=' + args.checks) + invocation = get_tidy_invocation("", args.clang_tidy_binary, args.checks, + None, build_path, args.header_filter, + args.allow_enabling_alpha_checkers, + args.extra_arg, args.extra_arg_before, + args.quiet, args.config, args.line_filter) + invocation.append('-list-checks') invocation.append('-') if args.quiet: # Even with -quiet we still want to check if we can call clang-tidy.