code review

This commit is contained in:
何童崇 2022-09-23 16:31:00 +08:00
parent a07dbdc0cd
commit 80960895c4
7 changed files with 1 additions and 145 deletions

View File

@ -1,9 +0,0 @@
import react from 'react';
function EmptyPage(){
return <div>
11111
</div>
}
export default EmptyPage;

View File

@ -1,69 +0,0 @@
// import { requireModule } from "alex";
import { EditorEmptyComponent } from "./editorEmpty.view";
import { EditorWelcomeComponent } from "./welcome.view";
const { AppRenderer, requireModule } = require('alex');
const CommonDI = requireModule("@opensumi/di");
const CoreBrowser = requireModule("@opensumi/ide-core-browser");
const Editor = requireModule("@opensumi/ide-editor");
const Theme = requireModule("@opensumi/ide-theme");
const { Injectable, Autowired } = CommonDI;
const { BrowserModule, Domain, ComponentContribution, getLanguageId , CommandContribution} = CoreBrowser;
const { BrowserEditorContribution } = Editor;
const { IIconService } = Theme;
const imageUrl =
"https://www.gitlink.org.cn/images/avatars/LaboratorySetting/1nav?t=1638344455";
@Domain(BrowserEditorContribution, ComponentContribution, CommandContribution)
export class WelcomeContribution {
@Autowired(IIconService)
iconService;
// 覆盖欢迎页
registerEditorComponent(registry) {
// 覆盖 alex 中的欢迎页
registry.registerEditorComponent({
uid: "welcome",
component: EditorWelcomeComponent,
renderMode: 3,
});
}
// 覆盖空白页
registerComponent(registry) {
registry.register("editor-empty", {
id: "editor-empty",
component: EditorEmptyComponent,
});
}
// 覆盖资源图标
registerResource(service) {
service.registerResourceProvider({
scheme: "welcome",
provideResource: async (uri) => {
const iconClass = this.iconService.fromIcon("", imageUrl, "background");
return {
uri,
name: "欢迎使用",
icon: `${iconClass} icon-background`,
};
},
});
}
// 注册获取语言命令 移除alex-app-plugin的同名命令
registerCommands(commands) {
commands.registerCommand(
{ id: 'alex.env.language' },
{
execute: () => getLanguageId(),
},
);
}
}
@Injectable()
export class StartupModule extends BrowserModule {
providers = [WelcomeContribution];
}

View File

@ -1,40 +0,0 @@
// import { requireModule } from "alex";
import { ToolBarRightBtn } from "./editorEmpty.view";
const { AppRenderer, requireModule } = require('alex');
const CommonDI = requireModule("@opensumi/di");
const CoreBrowser = requireModule("@opensumi/ide-core-browser");
const Editor = requireModule("@opensumi/ide-editor");
const Theme = requireModule("@opensumi/ide-theme");
const { Injectable } = CommonDI;
const { BrowserModule, Domain, MenuContribution , ToolBarActionContribution} = CoreBrowser;
// 注册 toobar 参考 https://github.com/opensumi/core/blob/main/packages/core-browser/__tests__/toolbar.test.ts
@Domain(ToolBarActionContribution, MenuContribution)
export class ToolbarContribution {
registerToolbarActions(registry) {
registry.addLocation('menu-right');
registry.setDefaultLocation('menu-right');
registry.registerToolbarAction({
description: '跳转标准版 Ant Codespaces',
component: ToolBarRightBtn,
id: 'toolbar-right-btn',
weight: 1,
preferredPosition: {
location: 'menu-right',
},
neverCollapse: true,
});
}
registerMenus(menus) {
// 由于目前 toolbar 尚未处理插件自定义组件展示因此先卸载掉toolbar的右键
menus.unregisterMenuId('kt/toolbar/context');
}
}
@Injectable()
export class ToobarModule extends BrowserModule {
providers= [ToolbarContribution];
}

View File

@ -1,11 +0,0 @@
export const EditorEmptyComponent = () => {
return <div>test empty page</div>;
};
export const ToolBarRightBtn = () => {
const clickFn = () => {
console.log(1);
};
return <button onClick={() => clickFn()}>跳转</button>;
};

View File

@ -1,8 +0,0 @@
import './welcome.view.less'
export const EditorWelcomeComponent = () => {
return (
<div >
test welcome page
</div>
);
};

View File

@ -1,4 +0,0 @@
.icon-background {
width: 50px !important;
background-color: #ccc !important;
}

View File

@ -27,8 +27,7 @@ import webSCM from './extensions/alex-ext-public.web-scm.js';
import * as SCMPlugin from './plugins/web-scm.plugin';
import * as AlexApp from './plugins/alex-app.plugin';
// import { StartupModule } from './module/Startup.module'
// import { ToobarModule } from './module/ToolBar.module';
import Welcome from './module/Welcome';
import './index.scss';
@ -103,8 +102,6 @@ const WebIDE = ( props) => {
},
}),
CodeAPIModule,
// StartupModule,
// ToobarModule,
],
extensionMetadata: [
css,